Anonymous Maarten
Anonymous Maarten
It would also be useful to write some documentation for the `docs` directory. Since openharmony is a relatively new os, documentation about how to package a SDL app would be...
> > Does it work? I changed the commit message > > Hmph. It still seems to run all the workflows. @madebr: Is the filtering correct? I'm using `${{ github.event.head_commit.message...
On pushes, `github.event` is a [push object](https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=synchronize#push), which has a `.`head_commit.message` property. On pull requests, `github.event` is a [`pull_request (synchronize)` object](https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=synchronize#pull_request). This objects does not have `.head_commit.message` property. Through `github.event.pull_request.commits_url`,...
> It is an existing bug in SDL GitHub workflow?! Yes and no. Yes because parsing commit messages do not work. No because pull requests creators cannot sneakily disable a...
This looks very great. I've got some questions. - This adds support for OpenHarmony 5. What compatibility promise does OpenHarmony make? Do apps built for older SDK's run on newer...
> Something I noticed on Windows when working on the D3D12 driver is that OpenXR's loader when compiled in debug mode produces a DLL named `openxr_loaderd.dll`, which is different than...
> > the sensible way is to always use `openxr_loader.dll` (without suffix) and require openxr-loader to be configured with `-DOPENXR_DEBUG_POSTFIX=`. > > Makes sense, although, when using the OpenXR SDK...
Looks like the OpenXR devs are not confident on this topic. They'd require extra testing to make sure mixing MSVC CRT's works. They suggested attempting to load both names. Perhaps...
Perhaps also add libopenxr-dev (for Ubuntu) and openxr-devel (for Fedora) to [`README-linux.md`](https://github.com/libsdl-org/SDL/blob/main/docs/README-linux.md#build-dependencies)? And add `libopenxr-dev` to [.github/workflows/create-test-plan.py](https://github.com/libsdl-org/SDL/blob/2e381a717f69b0231032687043e195d09901f109/.github/workflows/create-test-plan.py#L448-L456). (The first list is for Ubuntu 20.04+, the second list is 22.04+.
> I don't believe we need to, as I vendored the OpenXR headers same as was done for Vulkan. So we don't actually need the OpenXR dev packages on the...