Ayoub Mrini comments

Results 281 comments of


                                            Ayoub Mrini

WIP: test(baremetal/helper.go): use DeletePropagationForeground policy while deleting CRs to avoid leftovers

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-serial-virtualmedia-2of2 10

Set and check (and document) a global label_value_length_limit

we may also need to update the data model https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels

discovery: move openstack floating ips function from deprecated Compute API /os-floating-ips to Network API /floatingips

Yes, I'll resume the review (I'm not really familiar with the involved APIs, and I want to take some time making sure the new one doesn't break the current behavior)

discovery: move openstack floating ips function from deprecated Compute API /os-floating-ips to Network API /floatingips

This seems ready to me, just a few final touches. (I assume you gave this a try against a real API :))

Populate __meta_kubernetes_service_loadbalancer_ip from status.loadBalancer.ingress with fallback to spec.loadBalancerIP

thanks for this! could you add some tests in https://github.com/prometheus/prometheus/blob/main/discovery/kubernetes/service_test.go @tiesmaster shared some real world examples here https://github.com/prometheus/prometheus/issues/14398#issuecomment-2761037848

tsdb/wlog: Remove any temproary checkpoints when creating a Checkpoint

to close the loop and to provide more context, please note that a fix was tried in https://github.com/prometheus/prometheus/pull/16780

when discovered labels has conflicts, for example `__meta_kubernetes_pod_container_name`, we should be drop them instead of preserve the last one.

I thought `containerPort` was a required field, if one wants to define a port. After quickly looking over the code, I see the empty `container.Ports` case is handled in many...

when discovered labels has conflicts, for example `__meta_kubernetes_pod_container_name`, we should be drop them instead of preserve the last one.

Thanks for the details. Could you elaborate on why you cannot/don't want to define `ports.containerPort`? Although it's just informational, we rely on it (its concreteness) for discovery. Also I don't...

when discovered labels has conflicts, for example `__meta_kubernetes_pod_container_name`, we should be drop them instead of preserve the last one.

I honestly still don’t see where the problem is. the `TestPodDiscoveryInitContainer` test in https://github.com/prometheus/prometheus/blob/1b0f2b3017b0231afdbbf752971b363c5f91d135/discovery/kubernetes/pod_test.go#L306 shows that in this case both targets/containers are discovered, and the test does pass. You could...

feat: add support for metricLabelSelector with matchLabels

Hello @lelithium I knew someone would ask for this someday. I'm no longer able to do manual testing before releasing anymore, I'll be adding some tests (maybe some e2e). I'll...