Ayoub Mrini

Results 243 comments of Ayoub Mrini

This is related to https://prometheus.io/docs/prometheus/latest/migration/#scrape-protocols, which links to how to set up a workaround. `text/plain; version=0.0.4, charset=utf-8` uses `,` instead of `;` which fails the parsing https://github.com/golang/go/blob/4b652e9f5f5c0793f2e41cd2876bce5a241b2c95/src/mime/mediatype.go#L124-L135 (most if not...

https://github.com/prometheus/prometheus/issues/15830 tracks improving the doc regarding this.

> @machine424 - can I take up adding testing cases in util and increasing the coverage. Will add parallel test cases as well whenever I can Sure thing, thanks.

test is failing https://github.com/prometheus/prometheus/actions/runs/11038907137/job/30663187884?pr=14983#step:6:656, I'll push the fix now.

> Code looks ok to me. I fired up PromBench to see if the allocation shows up. > (But the base is a month off so may not be accurate)...

Now that I'm thinking about it, AFAIU, prombench doesn't cover `remote_read`, the only way we can make use of the `mergeGenericQuerier` within Prometheus itself. I think we can go with...

cc @sywhang I'd like to get this fix merged so we can make use of the feature. (when you have some time)