Ayoub Mrini

Results 281 comments of Ayoub Mrini

This will be also allow to get rid of https://github.com/prometheus/prometheus/pull/15447/files (hard to keep up to date)

cc @juliusv @Nexucis could you suggest how we can check for the min required npm/nodejs versions?

> > cc @juliusv @Nexucis could you suggest how we can check for the min required npm/nodejs versions? > > Honestly I don't know if there's a reasonable way to...

Thanks everyone, let's continue here https://github.com/prometheus/prometheus/pull/16832

> @machine424 Can we get a review here? Thanks for your efforts @paulojmdias! I would have preferred for us to continue discussing and working on this here https://github.com/prometheus/prometheus/pull/14112 so as...

FYI, a client per microversion seems to be an acceptable approach: https://kubernetes.slack.com/archives/C05G4NJ6P6X/p1718356577424199?thread_ts=1717601834.758229&cid=C05G4NJ6P6X

Thanks for this. Allow me to summarize: we already got https://github.com/prometheus/prometheus/pull/14312/files merged which allows using `original_name` when it's available; in other words, according to https://docs.openstack.org/api-guide/compute/microversions.html, if the server's `min_version` microversion...

As per my last comment, I’ll proceed to close this. Feel free to reach out if you have any further questions. Thanks!

Maybe we can close this one as a dup then?

Thanks for this! We’re working on a refactor of the sending logic in https://github.com/prometheus/prometheus/pull/16355 which should also address **some** of the points raised in the issues. Let’s revisit this once...