Ayoub Mrini

Results 195 comments of Ayoub Mrini
trafficstars

> LGTM besides the one open comment, but I guess I need to audit all of the remote write tests for failure cases in goroutines now! As of now, enabling...

> @machine424 I think we should merge this and see if it fixes the flake in CI it was waiting for an approval, then I made it a draft as...

Looking at the code, it may be because of https://github.com/prometheus/common/issues/790, so it may not be only related to `3.4.0` I'll mark it as a bug, PRs to work on this...

also the error seems to come from Thanos https://github.com/thanos-io/objstore/blob/a0136a6f898d43ec0e654a98ac322554f2ae259b/objstore.go#L439 (compactor downloading blocks from object store to compact them?) so it's better to check used and available (`du`/`df`) space on Thanos...