Ayoub Mrini

Results 248 comments of Ayoub Mrini

> /prombench cancel > > It's up for long time, cancelling to save credits (you can inspect the data in retrospective). Hope that's ok! Since the changes affect how compaction...

> > Might be useful for other operations (WAL writing? > > Would this require holding WAL records in memory until there is 4KB to write? That gives me mixed...

> What happens if you plot just file cache memory? There is one in here https://github.com/prometheus/proposals/pull/45/files Yes, less page cache should/will imply less page cache eviction.

Thanks for this. I don't think this is meant for Prometheus itself, which means this will always result in unnecessary traversals of the `errorExec` chains. For library use, we need...

Thanks, but I still believe that `util/grpcutil` doesn't belong in the Prometheus codebase. Instead, we could allow customization of the `apiError -> status code` mapping, assuming other maintainers agree to...

Thanks for sharing the details. It's about making tradeoffs with such changes, we want the code to be customizable with less overhead on your end, but we also want to...

cc @bboreham as a "prometheus as a library" user, FYI