Ayoub Mrini

Results 243 comments of Ayoub Mrini

Thanks for looking into this. A more logical solution for me would be to set `m.groups` to an empty slice (or even nil) after invoking `Stop()`. This way, when `Update()`...

Summarizing the discussion here and the one in the duplicate issue https://github.com/prometheus/prometheus/issues/13413, I think the steps we can take, ranging from simpler to more complex/tricky, are as follows (I'm not...

Thanks Julius for the update. I’m looking forward to trying out that new UI. Do you think there are some changes we can easily add to the current UI? For...

I'll give this a try. EDIT, I have a draft here: https://github.com/prometheus/prometheus/pull/13622

I'll re-open this as the attached fix only addresses the SD manager behind the `new-service-discovery-manager` flag. Personally, I do not plan to debug and fix this for the legacy/default DS...

Are you replacing the target files atomically? (Make your service open write to a temp file then rename/move it to the dir Prometheus is watching). Not familiar with Windows APIs,...

Having the two checks compete based on the order and how the expression is written is confusing and error-prone IMHO, don't we just want to: Suppose no buckets are needed;...

Yes, with such change, reloads are no longer dictated by the defaultWatchInterval (3 minutes), even when the kubelet has already updated the files. Instead, the updates will be mainly subject...

opened https://github.com/thanos-io/thanos/issues/8127

José, Thanks for working on this! Maybe the issue https://github.com/prometheus/prometheus/issues/15185 wasn’t clear. If the task were simply to add `t.Parallel()` here and there, I could have done that myself without...