Ayoub Mrini

/prombench restart main

/prombench cancel

The dashboards provide no indication of notable regression.

I don't think https://github.com/prometheus/prometheus/pull/14174 was meant to fix this, the `TestReApplyConfig` added here is still failing on main. I'll try to revive this with the fix I proposed here https://github.com/prometheus/prometheus/pull/13119#discussion_r1646384092

we can close this as https://github.com/prometheus/prometheus/pull/14987 was merged. Thanks again for looking into this.

> Wouldn't it be simpler to have two codecs ? Looking over the code, I think that unless one makes the two codecs have different `MIMEType` (which may be considered...

> There is some flexibility in negotiateCodec already. It doesn't only check MIMEType but also checks if the codec can actually encode the response, and it might fall back to...

Thanks for the report, This indeed looks like a data race. I assume the Prometheus instance can also serve such queries, so somewhere we try to run both the requests...

Bingo ``` ================== WARNING: DATA RACE Write at 0x00c0013ec178 by goroutine 24121: slices.insertionSortCmpFunc[go.shape.*uint8]() /opt/homebrew/Cellar/go/1.23.0/libexec/src/slices/zsortanyfunc.go:13 +0x194 slices.stableCmpFunc[go.shape.*uint8]() /opt/homebrew/Cellar/go/1.23.0/libexec/src/slices/zsortanyfunc.go:343 +0xbc slices.SortStableFunc[go.shape.[]*github.com/prometheus/prometheus/model/labels.Matcher,go.shape.*uint8]() /opt/homebrew/Cellar/go/1.23.0/libexec/src/slices/sort.go:38 +0x448 github.com/prometheus/prometheus/tsdb.PostingsForMatchers() /$/github/prometheus/tsdb/querier.go:237 +0x3f4 github.com/prometheus/prometheus/tsdb.selectSeriesSet() /$/github/prometheus/tsdb/querier.go:127 +0xac github.com/prometheus/prometheus/tsdb.(*blockQuerier).Select() /$/github/prometheus/tsdb/querier.go:118 +0x170...

Without the revert https://github.com/prometheus/prometheus/pull/14515, the test fails on my machine with: ``` === RUN TestBlockCompactionDuringRemoteRead unexpected fault address 0x1094fc063 fatal error: fault [signal SIGSEGV: segmentation violation code=0x2 addr=0x1094fc063 pc=0x10551712c] goroutine...