Results 341 comments of m4b

@kkent030315 gentle ping; would definitely like to see this go in, but I had requested some changes :)

@kkent030315 thanks for this PR, I think if we fix the basic nits this is ready to go, thank you!

I'd also like to see this one go in for sure :)

I'm interested in this for rust and iirc there isn't an HTTP version anymore, you need to use stdout/stdin. Also seems more "emacsy" to give a path to the binary...

Ditto have same crash: ``` Running `target/release/e-nguyen --fullscreen` Xlib: extension "NV-GLX" missing on display ":0". Xlib: extension "NV-GLX" missing on display ":0". [2019-04-06T19:24:31Z WARN e_nguyen::ewin] No discrete device was found....

I actually just got a similar device lost error during the drop call on another project when constructing an immutable image. I tested the project on an older Linux laptop,...

Cool ! Looking forward. Got kind of sad when same code failed on some slightly older hardware but so it goes. I’ll try to find some time to run with...

Are we sure the crash isn't here? https://github.com/e-nguyen/e-nguyen/blob/56d47a244c988a02252d25e487273832664d656b/src/settings.rs#L276 I thought I saw it during immutable image construction, and I'm also seeing vulkano crash there on an older linux laptop (on...

@glandium is there a patch you can contribute to fix this issue or make us more compliant?

can you rebase, CI had an issue on nightly