m4b
m4b
Needs rebase for CI to run
NB: non-breaking
is this still an issue? if yes, and it's a valid public field of a struct, then yes, I'd suggest to push a PR
https://github.com/m4b/goblin/pull/471#issuecomment-2972466261
needs rustfmt
@Kharosx0 this needs a rebase now; after that let's re-review now that permissive stuff has landed. You may be able to use the new trait to help with this, not...
@Kharosx0 are you still interested in this? If so, can you checkout the latest goblin, and see if the new parsemode permissive changes are working like your PR, as they...
this probably needs a rebase/my comments still need some clarification. we can focus on the other outstanding PR for delay import parser in the meantime though :)
Ah neat, yea I didn't see that feature. So adding `rtl8139` works to get a little further, and the logging on network init looks better, but it still fails with...
Ok, so I just I read the advanced section again, and noted it said if don't want to add taps can use dhcpv4 feature to transparently connect, and indeed, I...