m4b
Yea I had a feeling it was something like that :/ I wonder if we can enable both if you select either to preserve additivity? Perhaps a single elf is...
somewhat unrelated, i want to release a new scroll version, but i'm on the fence whether i should release as 0.12 or 0.11.1, since it updates MSRV and (imho) this...
Ok as i feared, trying out this patch in goblin causes several failures: ``` failures: ---- pe::section_table::tests::set_name_offset stdout ---- thread 'pe::section_table::tests::set_name_offset' panicked at 'called `Result::unwrap()` on an `Err` value: Scroll(BadInput...
I've decided to release scroll 0.12 without this patch; we can investigate the root causes to this later, but for now, happy new year!
friendly ping about the status of this? I'd like to see a proper fix here, but avoiding breakage, don't know if that has been resolved. re adding deps, there would...
That’s not good :/ must be something wrong with the scroll pwrite derive macro…
Would love if we got this fixed, @Frostie314159 did you manage to take a look at this? (I know you were working on other things, and thank you, just doing...
sounds good no rush, and if you don't feel like working on it, that's ok too :) anyway 0.12 scroll is out
There may be a reason for this, I'm not sure actually, would need to investigate; or it could just be an oversight, as you suggest
sorry for late reply :) i agree with replacing `CStr` impl, if there is a safe, std alternative, that seems good to me. as for others, well, I would have...