goblin icon indicating copy to clipboard operation
goblin copied to clipboard

PE: Support multiple debug directories and VCFeature metadata

Open kkent030315 opened this issue 10 months ago • 2 comments

This PR addresses the issue https://github.com/m4b/goblin/issues/314.

  • The change is straightforward. It makes the DebugData::image_debug_directory: ImageDebugDirectory into Vec<ImageDebugDirectory> as someone pointed out in the https://github.com/m4b/goblin/issues/314#issuecomment-1979849304. So this is to be an breaking change.
  • There is another addition of VC feature metadata IMAGE_DEBUG_TYPE_VC_FEATURE (IMAGE_DEBUG_VC_FEATURE_ENTRY) in the debug directory.

If anyone have suggestion of making this semantics without breaking the backward compatibility I am open to discuss.

kkent030315 avatar Apr 12 '24 02:04 kkent030315

@kkent030315 thanks for this PR, I think if we fix the basic nits this is ready to go, thank you!

m4b avatar May 13 '24 05:05 m4b

I'd also like to see this one go in for sure :)

m4b avatar May 20 '24 06:05 m4b