goblin
goblin copied to clipboard
PE: Support multiple debug directories and VCFeature metadata
This PR addresses the issue https://github.com/m4b/goblin/issues/314.
- The change is straightforward. It makes the
DebugData::image_debug_directory: ImageDebugDirectory
intoVec<ImageDebugDirectory>
as someone pointed out in the https://github.com/m4b/goblin/issues/314#issuecomment-1979849304. So this is to be an breaking change. - There is another addition of VC feature metadata
IMAGE_DEBUG_TYPE_VC_FEATURE
(IMAGE_DEBUG_VC_FEATURE_ENTRY
) in the debug directory.
If anyone have suggestion of making this semantics without breaking the backward compatibility I am open to discuss.
@kkent030315 thanks for this PR, I think if we fix the basic nits this is ready to go, thank you!
I'd also like to see this one go in for sure :)