m4b
Hmmm, thank you for the detailed writeup! Can you paste the binary by any chance with your fibonnaci function? I'm a little surprised this wouldn't have come up earlier, but...
if you `git revert eaba4ed4ae6a8054fd489dd011aeaf8609378b48` can you test if this repro's for you?
This would be a pretty enormous breaking change for goblin, and I'd hate to think of the ergonomic issues around dealing with strings from this Strtab after a change like...
hmmm, if i run `bingrep` on your exe, all the libraries functions it imports seem ok, so i don't think this is a general problem in our strtab parsing itself....
`get_cstr()` sounds like a _great_ compromise, did not think of that :)
I suspect you needed this portion: https://github.com//m4b/goblin/blob/17a5c7cc992220cd72e349eddea99148f31c5e65/src/pe/symbol.rs#L240
So for now I don't think I want to proceed with this; it will be too intrusive a change for everyone involved. I'm not convinced that switching everything to Cstr...
hi @manunio i would prefer not to sign up my email for this service, but if you feel like it and don't mind it, I don't see a problem with...
@manunio i thought we agreed your email is sufficient? Or they specifically need my email?
Usually the first step is to add Pwrite methods to the various PE structs, ideally deriving them (as I see your WIP PR appears to?). Then if you wanted, you...