Lee Yarwood

Results 141 comments of Lee Yarwood

> @rmohr @davidvossel @fabiand Do you recall why this is not included in today's Kubevirt? It's not supported by the default `q35` machine type we use in KubeVirt, that's why...

Ah I forgot about this check in the VMI admission webhook that predates my constant changes: https://github.com/kubevirt/kubevirt/blob/d5483221b7c78d702f2f24677b8788c58cfb7fed/pkg/virt-api/webhooks/validating-webhook/admitters/vmi-create-admitter.go#L2281-L2303

We should technically allow `ide` with the `pc` machine type but I assume there's a load of other checks that assume `q35` like this?

I'm not sure if we should also provide a warning if presets are referenced by a VirtualMachine and/or later applied to a VirtualMachineInstance?

Leaving this as draft until I've raised it on the ML and community meeting.

> So with the removal of VMIPreset, is there a replacement API to template VMI objects? Or will templating only be supported for VMs i.e. VirtualMachineFlavors Only with VMs through...

Yet to see any negative feedback regarding this proposal so I'm marking this as ready for review now. Obviously this doesn't close the door on further discussion so please do...

> @lyarwood when do you plan to release KubeVirt v0.56.0? I'm not involved with the release process but I will note [v0.56.0-rc.0](https://github.com/kubevirt/kubevirt/releases/tag/v0.56.0-rc.0) was just cut yesterday. That said this PR...

> > That said this PR is just introducing the deprecation and not the removal of VirtualMachineInstancePresets so it shouldn't matter which release this eventually gets into. > > That...