Lee Yarwood comments

Results 147 comments of


Lee Yarwood

instancetype: Apply instancetype to copy of VM during admission

@ShellyKa13 thanks again for looking at this, `cmp.Diff` pointed out the issue pretty quickly as documented in the [bug](https://github.com/kubevirt/kubevirt/issues/8435#issuecomment-1245561518), the PR should hopefully resolve this now.

instancetype: Apply instancetype to copy of VM during admission

/area instancetype /cc @akrejcir

Fix vm-cirros-cluster-csmall VirtualMachineClusterInstancetype name value.

/ok-to-test

Fix vm-cirros-cluster-csmall VirtualMachineClusterInstancetype name value.

/lgtm

Fix vm-cirros-cluster-csmall VirtualMachineClusterInstancetype name value.

/area instancetype

Fix vm-cirros-cluster-csmall VirtualMachineClusterInstancetype name value.

@jcanocan when you get a chance can you run `make generate` and push your branch?

Fix vm-cirros-cluster-csmall VirtualMachineClusterInstancetype name value.

/lgtm thanks!

Fix vm-cirros-cluster-csmall VirtualMachineClusterInstancetype name value.

/lgtm

Fix vm-cirros-cluster-csmall VirtualMachineClusterInstancetype name value.

/retest

`VirtualMachineSnapshot` of a `VirtualMachine` referencing a `VirtualMachineInstancetype` becomes stuck `InProgress`

There's definitely more to this but the following hack switching the order of the status update and finalizer addition fixes this for me locally, I'll continue looking tomorrow: ```diff #...