Lee Yarwood
Lee Yarwood
@brianmcarey any idea how I can get `tide` to trigger correctly here given `pull-kubevirt-fossa` has been dropped AFAIK?
/area instancetype /cc @fabiand /cc @dominikholler /cc @akrejcir /cc @davidvossel /cc @aglitke
> this is a neat idea. The primary concerns I have are about how to make this work in a consistent and predictable way. > > For example, I'm hesitant...
https://github.com/kubevirt/community/pull/190 posted, I'll rework the code in-line with this shortly.
/test pull-kubevirt-e2e-k8s-1.24-sig-storage
/test pull-kubevirt-e2e-k8s-1.24-sig-storage
> Great work @lyarwood! /lgtm > > I see that your new functest is failing, I'd be happy to re-lgtm when you fix these ACK thanks, I've fixed the timeout...
> It's coming from here: https://github.com/kubevirt/kubevirt/blob/v0.57.1/pkg/virt-api/webhooks/validating-webhook/admitters/vmclone-admitter.go#L270. > > This is relatively new, so you might tackle this after a rebase. In any case - if you're using a VM with...