Lee Yarwood
Lee Yarwood
Somehow we've updated the VM spec with the instancetype here? ```diff $ git diff -u diff --git a/pkg/virt-api/webhooks/validating-webhook/admitters/BUILD.bazel b/pkg/virt-api/webhooks/validating-webhook/admitters/BUILD.bazel index 63591eeaa..5375b68d1 100644 --- a/pkg/virt-api/webhooks/validating-webhook/admitters/BUILD.bazel +++ b/pkg/virt-api/webhooks/validating-webhook/admitters/BUILD.bazel @@ -48,6 +48,7 @@...
> @lyarwood guessing that this is the problem: https://github.com/kubevirt/kubevirt/blob/main/pkg/virt-api/webhooks/validating-webhook/admitters/vms-admitter.go#L102 > > Of course, we don't want the vm spec changing while the restore is in progress. Not sure how to...
/area instancetype
I'm going to close out this tracking issue as pretty much everything we wanted in by 0.58.0 is here now. Thanks all and onwards to [`v1beta1`](https://github.com/kubevirt/kubevirt/issues/8235)!
/hold FWIW the handling of the machine type env variable is broken here, I'll look more on Monday but in short you can't reuse the same machine type for x86_64...
> > /hold > > FWIW the handling of the machine type env variable is broken here, I'll look more on Monday but in short you can't reuse the same...
/hold cancel
/retest-required
/retest-required