Lukas Elmer

Results 17 comments of Lukas Elmer

@prc5 anything preventing this from being merged?

@iansu @mrmckeb anything preventing this PR from being merged?

I'd like to see that too :-)

> I personally find that this to be confusing & a little superfluous... I think the current description is fine and we probably don't want to inflate the docs further....

> I spent almost a full day pulling my hair out, as all the tests broke after upgrading - error messages, as always, unhelpful. > > This may be totally...

@OlivierCavadenti we just walked right into this issue. The doc MR https://github.com/knex/documentation/pull/475 would have helped a lot. Any chance this can get merged? Anything wrong with it?

We're also working in a monorepo, and we just updated to the new eslint version. The performance still seems to be a big issue - `import/no-cycle` is unusable like this....

I found out a couple of things: * Most time is spent within `ExportMap.parse` * Reducing the depth improves the situation: * Depth 1: 3.92s * Depth 2: 10.40s *...

Wow thanks for the quick reaction! > It has to parse every file fully in order to know what it imports/exports (or requires/module.exports, for CJS). Ok, I understand that. I...