Update the React 18 upgrade docs
What:
Update the React 18 upgrade docs
Why:
To make it easier to upgrade to React 18
How:
To document what the developer can do to upgrade to React 18
Checklist:
- [x] Documentation updated
- [x] Tests
- [x] Ready to be merged
- [x] Added myself to contributors table
I tested it manually on my React project
Deploy Preview for react-hooks-testing-library failed.
| Name | Link |
|---|---|
| Latest commit | 88ecaf03024602a55e2741aacbd315a774b8b0c2 |
| Latest deploy log | https://app.netlify.com/sites/react-hooks-testing-library/deploys/62f24ebb74462d0008515532 |
I personally find that this to be confusing & a little superfluous... I think the current description is fine and we probably don't want to inflate the docs further.
I personally find that this to be confusing & a little superfluous... I think the current description is fine and we probably don't want to inflate the docs further.
I would have helped me. And it seems I'm not the first it would have helped https://github.com/testing-library/react-hooks-testing-library/issues/832 https://github.com/testing-library/react-hooks-testing-library/issues/826 https://github.com/testing-library/react-hooks-testing-library/issues/842. But if you think it doesn't help others then feel free to close it.
I spent almost a full day pulling my hair out, as all the tests broke after upgrading - error messages, as always, unhelpful.
This may be totally obvious to people who've been working with testing-library for a while - I just dropped into a project and was asked to upgrade react to 18, and I've never used testing-library, so I don't have that context.
I had to read through numerous long issues, to finally find the explanation at the end of a long issue thread, pointing to this PR.
There's no reason for anyone else to go through that pain - I suggest you get this merged right away.
I spent almost a full day pulling my hair out, as all the tests broke after upgrading - error messages, as always, unhelpful.
This may be totally obvious to people who've been working with testing-library for a while - I just dropped into a project and was asked to upgrade react to 18, and I've never used testing-library, so I don't have that context.
I had to read through numerous long issues, to finally find the explanation at the end of a long issue thread, pointing to this PR.
There's no reason for anyone else to go through that pain - I suggest you get this merged right away.
Couldn't agree more :)
Codecov Report
Merging #841 (88ecaf0) into main (7a6e935) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main #841 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 245 245
Branches 34 34
=========================================
Hits 245 245
:mega: Weβre building smart automated test selection to slash your CI/CD build times. Learn more