create-react-app icon indicating copy to clipboard operation
create-react-app copied to clipboard
verified publisher icon facebook

fix(react-scripts): do not set allowedHosts if undefined

Open ylemkimon opened this issue 3 years ago • 3 comments

Fixes #11762.

urls.lanUrlForConfig may be undefined, if the HOST is set, the IP address is not private, or the IP address retrieval has failed.

TEST PLAN: manual testing with the steps to reproduce #11762.

ylemkimon avatar Jan 03 '22 05:01 ylemkimon

Can this please be merged so projects can use cra ^5 and proxying?

daweimau avatar Apr 23 '22 09:04 daweimau

Could this please get reviewed and merged? The issue currently prevents us from updating CRA.

BalzGuenat avatar May 09 '22 14:05 BalzGuenat

@iansu @mrmckeb anything preventing this PR from being merged?

lukaselmer avatar May 09 '22 14:05 lukaselmer

What is blocking this fix? Just encountered this bug that was reported in 2021.

soerenBoisen avatar Apr 24 '23 13:04 soerenBoisen

What is blocking this fix? Just encountered this bug that was reported in 2021.

Yeah very good question

lukaselmer avatar Apr 25 '23 22:04 lukaselmer