react-zoom-pan-pinch Publish src folder

This adds "src" to the set of published files, which allows source mapped URLs to resolve for consumers of this package. Resolves #265.

If the download size of the package is what we want to optimize for, an alternative approach would be to remove source map URL comments from the production build of this package.

Dec 17 '21 23:12 Abe27342

This is a pretty huge issue honestly. It makes it really hard to see real errors in the build using React scripts 5. Could this be merged?

Jan 04 '22 08:01 kokarn

Any updates on this? Really hoping to get a fix to this since it clutters the whole screen with bunch of warnings.

Jan 07 '22 08:01 ttannerma

I would also be really happy to have it merged or otherwise solved! Can't see much else on the console with these 28 warnings.

Jan 12 '22 17:01 OAndris

+1 for getting this merged, it's throwing a lot of warnings on react-scripts^5

Jan 27 '22 15:01 samwaters

same here, getting a lot of errors on after migrating to react-script-5, would love a solid merge :)

Jan 31 '22 22:01 royair

This was blocking enough for me that I decided to publish myself in the meantime npm -i @kokarn/react-zoom-pan-pinch is pretty much exactly this PR, only removed a few things that wasn't needed to in the package to reduce bundle size

Feb 01 '22 07:02 kokarn

The weird thing is, i edited package.json locally but it did not seem to solve the problem

Feb 01 '22 07:02 royair

The weird thing is, i edited package.json locally but it did not seem to solve the problem

If you only edit the package.json nothing will change in regards to using my temporary package.

Feb 01 '22 08:02 kokarn

oh i guess i also have to build the project in order of the package.json change to take effect, btw, is this project still maintained? I dont see any late commits...

Feb 01 '22 09:02 royair

oh i guess i also have to build the project in order of the package.json change to take effect, btw, is this project still maintained? I dont see any late commits...

You have to run install and build, yes

Feb 01 '22 09:02 kokarn

i tried to build but got rolllup related errors

Feb 01 '22 11:02 royair

I can't seem to find the repo @kokarn , what did you remove?

Feb 02 '22 21:02 jelizarovas

I can't seem to find the repo @kokarn , what did you remove?

I set package.json files to this and did a build

  "files": [
    "dist",
    "src/components",
    "src/constants",
    "src/core",
    "src/hooks",
    "src/utils"
  ],

Feb 02 '22 22:02 kokarn

i still have the 30 warning like this one

WARNING in ./node_modules/react-zoom-pan-pinch/dist/index.esm.js Module Warning (from ./node_modules/source-map-loader/dist/cjs.js): Failed to parse source map from '/.../node_modules/react-zoom-pan-pinch/src/utils/styles.utils.ts' file: Error: ENOENT: no such file or directory, open '/.../node_modules/react-zoom-pan-pinch/src/utils/styles.utils.ts'

even after installing @kokarn/react-zoom-pan-pinch

any fix is comming ? thanks

Feb 23 '22 08:02 alainib

even after installing @kokarn/react-zoom-pan-pinch

what version?

Feb 23 '22 08:02 kokarn

even after installing @kokarn/react-zoom-pan-pinch

what version?

@kokarn/react-zoom-pan-pinch @ 2.1.15

it work now thanks :)

I removed yarn cache completly and run yarn install a second time. first time i just remove react-zoom-pan-pinch and installed @kokarn/react-zoom-pan-pinch

Feb 23 '22 08:02 alainib

@prc5 anything preventing this from being merged?