Lukas Kahwe Smith
Lukas Kahwe Smith
either way, I guess in the dev env the expectation is to not have to manually clear caches
can you test master?
I propose to deprecate this Bundle in favor of https://github.com/Sylius/SyliusThemeBundle cc @pamil
I guess this might also enable referencing a non themed template from the themed template with the same "name"
its always easier to review code in a PR .. so open up the PR and we can discuss. note you can update a PR by simply pushing to your...
yes and no. before you made the change to set defaultRoute to null if no fallabck route was set, I would have exepcted the tests if the case of not...
ah that is indeed possible. only on my ipad atm .. but it appears that at least parts of the ThemeController are being tested inside https://github.com/liip/LiipThemeBundle/blob/a78e762b68c6a44096f6a4fe4ca6d16a00952ebe/Tests/UseCaseTest.php
yeah but maybe this would serve as inspiration for a new test. anyway I truly to have a closer look and give more concrete hints tonight or tomorrow
@AsfalothDE Just had a look: I would do a unit test. ie. in a new test case in `UseCaseTest`, make an instance of `ThemeController` passing in the relevant dependencies (I...
ok great .. thank you for investing the time into finalizing this PR