LiipThemeBundle icon indicating copy to clipboard operation
LiipThemeBundle copied to clipboard

Newly added theme files not located until cache cleared

Open drjones69 opened this issue 10 years ago • 3 comments

Good afternoon, Just started with LiipThemeBundle - so apologies if I'm trying to run before i can walk.

I have set up 2 themes (say, Brand1 and Brand2) and set fallback to Resources/views/

If I have a template which loaded from the fallback - this works. If I then place a template in (say) Resources/themes/Brand1/ and reload the page, it still pulls the template from the fallback.

Once I clear the cache though, the newly added override template is (correctly) loaded.

I think the cause is down in the Liip\ThemeBundle\Locator\TemplateLocator::locate method - as I understand things, once a template is added to the cache, the locator method then relies on this rather than relocating the template.

Would this be better to use the %%kernel_debug%% value, and always relocate the template if the app is in an environment with debug=true?

Regards, Ryan

drjones69 avatar Apr 11 '14 13:04 drjones69

For this purpose Symfony has cache warmer and bundle is replacing templating.cache_warmer.template_paths with liip_theme.templating.cache_warmer.template_paths. And here Kernel is deciding call it or no.

oleg-andreyev avatar Apr 11 '14 17:04 oleg-andreyev

either way, I guess in the dev env the expectation is to not have to manually clear caches

lsmith77 avatar Apr 12 '14 07:04 lsmith77

can you test master?

lsmith77 avatar May 09 '15 08:05 lsmith77