Lukas Kahwe Smith comments

Results 397 comments of


                                            Lukas Kahwe Smith

Add custom twig loader to workaround cache issue

@dantleech / @xanido can you get this wrapped up?

Add custom twig loader to workaround cache issue

ping

Kernel not cleaned up in getContainer()

we do a lot of iffy stuff with the kernel to also get access to the container. there might be something bad happening indeed.

Twig namespaced paths

this PR is now merged

Create Theme as ValueObject and add theme inheritance

One thing to keep in mind here is that some users have dynamic themes, aka they do not hardcode the list of themes. i don't really want to complicate their...

Create Theme as ValueObject and add theme inheritance

both ..

Create Theme as ValueObject and add theme inheritance

so in other words to convince me .. you will have to present a more complete argument .. maybe the others are easier to convince :)

Create Theme as ValueObject and add theme inheritance

ok .. talked to some people ... and it seems there is demand for this feature. can you make a proposal for an implementation?

Create Theme as ValueObject and add theme inheritance

as for your question from above .. i tend toward b) as this will likely make the life easier for people with dynamic themes

Create Theme as ValueObject and add theme inheritance

I think finding a solution for A/B testing is certainly interesting. That being said, its certainly a whole new level of complexity that you describe above. So if someone does...