Lukas Kahwe Smith
Lukas Kahwe Smith
with Request mock, you mean the Request instance? I don’t think you need to mock the Request object since its essentially just a value object at any rate if it...
ok. just commit what you have. this will make it easier for me to give you pointers.
@AsfalothDE I send a PR to your PR branch :) https://github.com/AsfalothDE/LiipThemeBundle/pull/1 first up sorry .. I was mostly doing reviews of your PR on my iphone or ipad so I...
ok great .. I think the last detail is handling the BC issues I noted and then we can merge.
can you elaborate a bit what you mean? indeed its a known issue that assetic cannot pick up assets in all locations but I do not see what alternative we...
Hmm .. not sure why we never considered this (a long time ago we made this decision .. not sure if I am forgetting something) .. it feels a bit...
btw for anyone wondering about what issue is being addressed here: https://github.com/liip/LiipThemeBundle#assetic-dump-do-not-check-resourcesthemeviews-
@thormeier / @dbu can you check this?
@kriswallsmith do you have a hint here maybe?