Marcin Kolny
Marcin Kolny
> WAMR performs boundary checks by intercepting global.set __stack_pointer. Yes, and I think this check will have to be disabled for spawned threads. I think the extra pass shared by...
@sbc100 thanks, I think that's enough for now. I wonder though if there's any plan to integrate it to LLVM in a (near) future?
Thanks Andrew for the report. I think the default compiler configuration in build.sh is far from being perfect; this is what we have in the wasi-testsuite repo to build it:...
Hi, sorry for late reply. > Interesting; with [wasi-sdk-20+threads](https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-20%2Bthreads) is the "build wasi-libc again" step necessary any more? Most likely not, I'll try to upgrade it (update: https://github.com/WebAssembly/wasi-testsuite/pull/69) > why...
I wasn't able to reproduce your issue using wasi-sdk-20. What's the SDK version you use? Also, could you check if `assert.h` is in your sysroot (should be in `=$WASI_SDK_DIR/share/wasi-sysroot/include/assert.h`? It...
@g0djan have you defined stack size in the command? Is it possible that the test goes beyond the stack? Also, what's the max memory defined?
Thanks for the change, and sorry for being late with the review. I'll try to get to it by end of this week.
Hi @lum1n0us , you're right, the goal is to verify: 1. completeness 2. correctness of WASI implementation in the runtime. At the moment there's no way (at least in wasi-testsuite)...
> @loganek do you have any early feedback about the api? I left a few comments. It looks ok to me in general, although I'm not really sure if we...
Hi @lum1n0us I think the idea was briefly discussed in this ticket: https://github.com/WebAssembly/WASI/issues/595 So basically the `*-module` is a foundational part for building the adapter, and the target in the...