Marcin Kolny

Results 111 comments of Marcin Kolny

Hmm, I can't imagine making the change without modifications of the wasi-libc; the wasi-libc code is the only place where the caller-supplied buffer is available. Once the preview2 function is...

@lukewagner ok looks like we both talked about the same thing :) So we both agree that wasi-libc changes are necessary - I'll prepare a brief plan with changes and...

Hi @xwang98 I think there important thing to know is that there's a `cabi_realloc` method implemented in WASM code that must be imported by the runtime. The runtime calls this...

@xwang98 I was mainly interested in the preview2 to preview1 adapter scenario and I don't think there's a need for more than one pointer (but didn't look at the all...

Hi @woodsmc , some functionality is already implemented (see here for the most up-to-date version: https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/shared/platform/windows/win_socket.c) but not all (having said that, I don't think it'd be a lot of...

Thanks for raising this RFC. I'm not sure if deleting the tests only because they fail is the right approach. For failing tests, we should verify if the test is...

> And this issue introduces a new stack frame structure so there will be two stack frame structures, different option combinations may use different stack frame structure. I'll need to...

> Re-using AOTFrame structure is also good, but had better use fixed offsets to get the field func_index and ip_offset and treat both of them as uint32 for the tiny...

Initially I thought that func_idx will always be needed. However, just having another thought on that, when the user is interested in both function index and instruction pointer, they could...

Thanks @jammar1 . Do you think it'd be good to setup a dev branch so you can post incremental Pull requests or you'd rather just make one big request with...