Marcin Kolny

Results 111 comments of Marcin Kolny

@hangedfish getaddrinfo is already supported, see https://github.com/bytecodealliance/wasm-micro-runtime/issues/1336 for details

@sophia-szady looks like this PR got stuck and there was no progress on that since last year. Do you think we should close it? @wenyongh any thoughts on that?

I think I saw that in wasmtime; every time the wasi function is called, it locks the memory mutex, to make sure the linear memory is protected. I don't think...

Completely agree, I don't think there's an automatic way to find all the WASI functions that access linear memory (the call of `validate_native_addr` gives us a hint, but what if...

@wenyongh just one more thought on that; users can expose custom native functions to WASM; don't you think we should in that case expose a public API for them to...

> I didn't add lock for the wasi function, could your team help do that after this PR is merged? Quite likely, but I'll confirm that later today. > Yes,...

@wenyongh we've discussed the case with the team and came to a conclusion that it should rather be user's responsibility to add or remove a lock in the application itself...

> BTW, could you help review PR https://github.com/bytecodealliance/wasm-micro-runtime/pull/2815? Should we add lock for aot_memmove and aot_memset? I think the problem with `aot_memmove` and `aot_memset` is similar to WASI functions -...