Marcin Kolny
Marcin Kolny
> * When are timestamps attached to events? At the flush of a buffer, or at the moment the event happens? Events are timestamped when the event happens in the...
> So one solution would be to include the thread ID in the name of the event, as a sort of prefix? Or would this only work when users explicitly...
@nikhilkotian22 I think it's fair to slightly de-scope this ticket and say it's really about covering ChromeTraceConverter with tests. I'm glad you consider picking this up, please let me know...
> Do you have an example of the expected events input to the trace output? Let's start with a known data initially and keep increasing later on? @nikhilkotian22 I think...
Hey @andrewrch any progress on that issue? :)
Thanks for the update :) No rush, just wanted to know if you had a chance to look into this and if there's anything I could help you with.
We'll definitely have more PRs for sockets, but none of the changes we have in the branch are breaking WAMR so I think it's safe to merge. Having said that,...
> the signatures of sock_addr_local/sock_addr_remote/sock_addr_resolve @wenyongh I understand your concerns and I agree those APIs have changed. However, they did not have the implementation, so I'm not sure if there's...
We've internally performed the tests and the PR is ready for review and merge. @wenyongh could you remove a `draft` flag from the PR and have a look? Thanks.
Thanks @JamesMenetrey for the feedback. Whereas I'm yet to come up with a concrete proposal, I think it's probably better to keep sample apps and tests separate, as their purpose...