Marcin Kolny
Marcin Kolny
> running memory32 wasm/aot files is not possible (though you can still run memory32 wasm/aot files with the default runtime compile without adding the cmake flags) I wonder if we...
> So we can change those types to: > > typedef mem_offset_t = uint32/uint64; based on CMake flag > uintptr_t; > uint64; I'd strongly discourage us from using `uintptr_t` -...
Thanks @gajanak , this is a known issue and we were planning to address it as part of the WASI work (overall, memory64 support is in still quite an experimental...
> i'm interested to help. Hi all, because a few teams are interested in the exception handling support in WAMR, I'll be hosting a meeting 1st of February at 7AM...
@wenyongh thanks for letting me know, I'll do that. The pr is in the draft state yet so I fix the ci failures and do a self review; I'll switch...
@wenyongh / @TianlongLiang I think the code is ready for review, I'd appreciate your feedback.
> But since Tianlong and I are in holiday in the left of this week, we might response slowly then. no worries, enjoy your holiday :)
> adding a command line option like --enable-memory64 in wamrc so that user can opt it out like user can choose to --enable-multi-thread and --enable-gc, in this way, I think...
> it's rather important to fail when it's expected to fail because, in case of aot, it's wamrc's resposibility to validate the module. I agree it's important, I don't think...
@wenyongh I've addressed all the comments, thanks a lot for the review. Unless there are any other comments, the PR is ready for merge.