Joachim Løvgaard

Results 74 comments of Joachim Løvgaard

I created a library for EditorJS which takes another approach to handling the JSON: https://github.com/Setono/editorjs-php :)

I agree @eskayamadeus. A PR would be awesome 🎉

Oh, that's an easy fix also. Didn't even know that. I am just beginning Psalm :) I think it would make sense that the plugin did this automatically. Given the...

I think optional attributes should be nullable. As mentioned before in the future we will probably implement an event system where users can plug in to events. These events will...

Nested indices are not allowed (https://support.google.com/webmasters/answer/7451001).

Cast on setting so you only do it once. No reason to delay it. That's my opinion :)

> Allow default routing to still work with on the fly generation, which can be disabled/enabled via a setting I think this should be disabled by default basically because it's...

I am not sure this is the better approach now. I like installation instructions like this: https://github.com/Setono/SyliusFeedPlugin#step-6-using-asynchronous-transport-optional-but-recommended

I also have the cost price plugin, but it's an overkill for just one property :D I like the idea of having a cost price per supplier, but I would...