sitemap-plugin icon indicating copy to clipboard operation
sitemap-plugin copied to clipboard

Published 20 hours ago • verified publisher icon stefandoorn

setChangeFrequency casts to string

Open stefandoorn opened this issue 6 years ago • 1 comments

Should we cast it on setting, or should we cast it on getting (or parsing)?

See https://github.com/stefandoorn/sitemap-plugin/blob/673fcd6b5b3d556053ef9d761e54583986f94e59/src/Model/Url.php#L63

stefandoorn avatar Jul 01 '19 13:07 stefandoorn

Cast on setting so you only do it once. No reason to delay it. That's my opinion :)

loevgaard avatar Jul 02 '19 06:07 loevgaard