Joachim Løvgaard

Results 77 comments of Joachim Løvgaard

Hi, @vasilvestre. Can you rebase this on `0.12`? Then we will merge it. Thank you 🎉

Totally agree. I have never made a recipe before. If I make the repository, are you up for the task? :)

Yeah, that's probably right, that you make a PR on that repository :)

I agree. Right now you don't get any feedback if you don't input anything either: https://user-images.githubusercontent.com/2412177/146510719-cd755710-d9e7-4c2e-82bc-e3b8438a3e0e.mov or when you input something wrong: https://user-images.githubusercontent.com/2412177/146510841-85a5bd94-c453-4caa-8cd6-b77cce117ce9.mov

Weird, maybe I didn't clear my cache completely. Thanks

Thanks for your solution here, @tuxes3. I really like it and I think we should implement this decorator in the plugin and add a few lines to the readme explaining...

Btw. we also have the rule `\Setono\SyliusGiftCardPlugin\Promotion\Checker\Rule\HasNoGiftCardRuleChecker` which more or less does the same as my idea, but you still have to actively do something

Gift cards are not required to have any association with a customer, but for gift cards bought on orders this could be an option. Not a bad idea with the...

For the first version of this feature I don't think we should have the toggle in the backend, but just as a configuration option.