sitemap-plugin icon indicating copy to clipboard operation
sitemap-plugin copied to clipboard

Model setters with optional values (nullable)

Open stefandoorn opened this issue 6 years ago • 1 comments

I think we should get rid of this kind of setter parameters:

  public function setter(?string value): void;

If such setters still exist after #92, we might make it non-nullable. Either provide a string, or not use the setter at all in the implementation layer.

stefandoorn avatar Jul 01 '19 13:07 stefandoorn

See my response in #92

loevgaard avatar Jul 02 '19 06:07 loevgaard