Luke Emmerson-Finch

Results 58 comments of Luke Emmerson-Finch

@nicktitchmarsh Claire and I have gone through our reds and tweaked accordingly. This PR should fix this: https://github.com/Sage/design-tokens/pull/214 Are you using the token 'colors.semantic.negative.500' for error text? If yes, then...

@robinzigmond Currently the width of the buttons is set to hug the inner content by design. I'd need review the proposed fixed width design to see whether we want to...

@Parsium i never received a design to review I'm afraid. We definitely need a decision log whether we can share screenshots and context imo.

@Parsium reviewed with @wkustrzykSage and we're fine to go ahead with the creation of this full-width prop from a DS perspective.

@nicktitchmarsh does Anrushi's latest message change your perception of the bug? You are correct that we will be considering deprecating tooltip at some point in the future.

@edleeks87 please can we remove the title tooltip on either part of this component. This appears to be the conventional pattern across competitors.

@Parsium and @rawlmp will need more context before i can review. Pelase can you share a spec or design.

Having reviewed @lukepricesage designs, i think adding an optional width prop that allows passing of custom width depending on resolution makes sense. Just to confirm @StylianosKoidakisSage - this wouldn't replace...

@Parsium and @rawlmp please can i see some designs to review. If we want to introduce this, i'll need to create a ticket for the DS team to contribute back...

@niamhmadden24 please could you share the proposed design via teams with Claire Denning and myself so we can review.