carbon
carbon copied to clipboard
Sage
MenuItem component to take iconAlign prop when there is an external link
Desired behaviour
There is an 'iconAlign' prop available to pass to the MenuItem component when there is an external link. This will allow us to position the icon to the right of the text.
Current behaviour
There is no 'iconAlign' prop available to pass to the MenuItem component. This means that when dealing with external links in Menus we can't use the 'icon' prop as this positions the icon to the left of the text, when it should be to the right.
Suggested Solution
iconAlign prop as available in the Link component.
Here: https://carbon.sage.com/?path=/docs/link--with-icon-align
CodeSandbox or Storybook URL
No response
Anything else we should know?
No response
Confidentiality
- [X] I confirm there is no confidential or commercially sensitive information included.
@ljemmo would you be able to run this past the DS team please and let us know if you want this feature or not? Thanks 😄
@niamhmadden24 please could you share the proposed design via teams with Claire Denning and myself so we can review.
Hi @niamhmadden24, are you able to share the design with Claire and Luke please? :)
I'm so sorry. I didn't see these comments @ljemmo @Parsium. I'll share the info via teams now.
@niamhmadden24 and @Parsium - Just reviewed and happy for us to go ahead with niamh's proposal from a DS perspective. They basically just wanting to enable left or right alignment of icons within child items. Currently we appear to only be able to pass in left-aligned icons.
@davidsmallman from a DS perspective, we're happy for this to go ahead. Do you want to create a ticket on their backlog with technical requirements or a member of the FEET team can? I believe usually the FEET team like to create their own tickets so that all the correct A/C points are added based on the original bug.
Thanks @ljemmo, appreciate it. Would be great if someone from FEET could and I'll link it to the corresponding Jira bug.
