carbon icon indicating copy to clipboard operation
carbon copied to clipboard

Button Toggle Group cannot apply width adjustment

Open wkustrzykSage opened this issue 2 years ago • 2 comments

Current behaviour

As a developer, I cannot set the width of the Buttons inside the ToggleButtonGroup component. It's also not possible to set ToggleButton Group to be full width. and set position to center if neededcentre

Expected behaviour

As a developer, I want to be able to set the width of the ToggleButton Inside ToggleButtonGroup and the possibility to set the position of buttons without adding extra ugly hacks

CodeSandbox or Storybook URL

https://codesandbox.io/s/zen-morse-4kpu2w?file=/src/index.js

JIRA Ticket (Sage Only)

SBS-41388

Suggested Solution

No response

Carbon Version

110.1.1

Design Tokens Version

2.40.0

What browsers are you seeing the problem on?

Chrome, Microsoft Edge

What Operating System are you seeing the problem on?

Windows

Anything else we should know?

No response

Confidentiality

  • [X] I confirm there is no confidential or commercially sensitive information included.

wkustrzykSage avatar Sep 21 '22 07:09 wkustrzykSage

@ljemmo what are your thoughts on this? Is this something we should provide in Carbon?

robinzigmond avatar Sep 27 '22 12:09 robinzigmond

@robinzigmond Currently the width of the buttons is set to hug the inner content by design. I'd need review the proposed fixed width design to see whether we want to support this in figma/carbon. Please feel free to DM me the design in question @wkustrzykSage

ljemmo avatar Sep 27 '22 16:09 ljemmo

Hi @ljemmo @wkustrzykSage, did you guys get to a verdict on this one?

Parsium avatar Nov 01 '22 14:11 Parsium

We do have this already on our backlog, but we'll block this for now

FE-5493

Parsium avatar Nov 01 '22 14:11 Parsium

@Parsium i never received a design to review I'm afraid. We definitely need a decision log whether we can share screenshots and context imo.

ljemmo avatar Nov 01 '22 15:11 ljemmo

@Parsium reviewed with @wkustrzykSage and we're fine to go ahead with the creation of this full-width prop from a DS perspective.

ljemmo avatar Nov 03 '22 12:11 ljemmo

Brilliant thanks for letting us know @ljemmo, I'll unblock FE-5493 👍🏼

Parsium avatar Nov 03 '22 14:11 Parsium

:tada: This issue has been resolved in version 111.14.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

carbonci avatar Dec 07 '22 09:12 carbonci