Luke Emmerson-Finch

Results 58 comments of Luke Emmerson-Finch

@nicktitchmarsh Correct, i would expect the Definition list to consume the styling of our link component when used in that context. There should be no manual styling going in here.

@edleeks87 for me to comment, i'd have to see the design to understand why this was requested. Ideally we'd want to keep this component as simple as possible and include...

@nicktitchmarsh i'll defer to martin on this one for the overall say on truncation from an accessibility perspective. My gut feel is that we shouldn't be allowing truncation on fields...

@tempertemper please could i get your thoughts on the above screenshot. I believe our guidance would be to suggest wrapping of labelling and getting the fields to the right to...

@benwilsonsage FYI - i know there's some SBS designers looking into this currently which could unblock this issue.

@DipperTheDan I've seen a few requests for this. It would be a variation/prop needed where can specify a fixed width override on the input field only where. By default though,...

@nicktitchmarsh This component is currently a pending issue proposed by Anwar on the SBS Product Design backlog: https://github.com/Sage/design-system/issues/29 I believe that we are waiting for him to take his proposal...

@mkrds If no error message or label is shown, i would expect the validation bar to be the height of the dropdown. However, i wouldn't ever expect an error to...

@nicktitchmarsh Ah yes, i remember working on the fieldset group variation that you're referring to for Client Management. I believe latest accessibility guidance is to move away from patterns such...

@nicktitchmarsh, @WojciechMichalowski and @DipperTheDan do we know why this override was requested? I believe the current hardcoded height is by design. I think if there's enough of a strong rationale,...