carbon
carbon copied to clipboard
Sage
Link tooltip doesn't work as expected
Current behaviour
If Link with Icon is enclosed in tab Tab title is displayed as tooltip for Link text.
(Link icon shows correct tooltip but when you hover over link text then tab title is displayed as link tooltip)
Expected behaviour
Tooltip message should display correctly
CodeSandbox or Storybook URL
https://codesandbox.io/s/new-brook-i6q4hl?file=/src/index.js
JIRA Ticket (Sage Only)
No response
Suggested Solution
No response
Carbon Version
106.1.0
Design Tokens Version
2.24.0
What browsers are you seeing the problem on?
Chrome
What Operating System are you seeing the problem on?
Windows
Anything else we should know?
No response
Confidentiality
- [X] I confirm there is no confidential or commercially sensitive information included.
Hi @AnushriJajoo2019, the Link behaviour of only showing the tooltip over the icon is intended . We could raise an issue with Design System to see if this is something they would like to change. I know from an accessibility standpoint we are trying to not use tooltips as much as possible as the content is hidden for screenreader users.
The Tab title is due to the parent div having a title prop on it
@ljemmo, Anushri seems to think Links should show the tooltip on hover of the link as well as the Icon. However our current implementation only shows on hover of the Icon. Is this something we could include in Carbon by default? I have no other context here for you I'm afraid
The issue is, I don’t want any tooltip on my icon or icon text , but still by default on hover of icon text , tab title is displayed as icon text tooltip.
From: Nick Titchmarsh @.> Sent: 20 September 2022 13:50 To: Sage/carbon @.> Cc: Jajoo, Anushri @.>; Mention @.> Subject: Re: [Sage/carbon] Link tooltip doesn't work as expected (Issue #5480)
EXTERNAL EMAIL
@ljemmohttps://github.com/ljemmo, Anushri seems to think Links should show the tooltip on hover of the link as well as the Icon. However our current implementation only shows on hover of the Icon. Is this something we could include in Carbon by default? I have no other context here for you I'm afraid
— Reply to this email directly, view it on GitHubhttps://github.com/Sage/carbon/issues/5480#issuecomment-1252307577, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANR4S2HFNAPFVWZXXP72VODV7GXHDANCNFSM6AAAAAAQNM6KPA. You are receiving this because you were mentioned.Message ID: @.@.>>
[Sage]
If you've received this email by mistake, we're sorry for bothering you. It may contain information that's confidential, so please delete it without sharing it. And if you let us know, we can try to stop it from happening again. Thank you. We may monitor any emails sent or received by us, or on our behalf. If we do, this will be in line with relevant law and our own policies. Sage (UK) Limited. Registered in England at C23 - 5 & 6 Cobalt Park Way, Cobalt Park, Newcastle Upon Tyne, United Kingdom, NE28 9EJ. Registered number 1045967. Sage, Sage logos, and Sage product and service names are the trademarks of Sage Global Services Limited.
The information contained in this email transmission may constitute confidential information. If you are not the intended recipient, please take notice that reuse of the information is prohibited.
@nicktitchmarsh does Anrushi's latest message change your perception of the bug? You are correct that we will be considering deprecating tooltip at some point in the future.
It is a bug imo, the title prop is being passed to the DOM element as it's lower case and a valid attribute, we could update to a later version of styled-component as they have a feature to filter anything that should be non-DOM but this will potentially have a big impact on MFEs so I think for now we should update the prop passed to the underlying Styled... elements to be tabTitle
@edleeks87 please can we remove the title tooltip on either part of this component. This appears to be the conventional pattern across competitors.
No problem I'll be picking up a separate ticket that requires a small update to Tabs so I'll just fix this at the same time
:tada: This issue has been resolved in version 111.3.3 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
