Chen Liang
Chen Liang
Should we use jetbrains or javax? javax annotations imo are not sustainable in long term as we might have things like nested nullable types
With jetbrain annotations/other type annotations and some tweaks to https://github.com/FabLabsMC/fiber/blob/9096f8160b17a882bc3bab3ac7ba0c822dff6948/src/main/java/me/zeroeightsix/fiber/annotation/magic/TypeMagic.java#L34, it will be able to handle the nullability of nested types properly
Yep, but a problem with jetbrain annotations is that they are class-level retention (i.e. aren't exposed at runtime so config's type resolution cannot perform nullable checks unless using asm to...
> > > Does checker preserve annotations into runtime? https://github.com/typetools/checker-framework/blob/6cf4e4f2cb829bb39a3bc33f3a11b547f3afe3dd/checker/src/main/java/org/checkerframework/checker/nullness/qual/Nullable.java#L27 It does
I recommend adding a minimal test case for this bug, like the one from the JBS issue.
> Is it ok to just out bug-related test into some pre-existing test class? I just saw that issue-related tests are all in separate folders so figured its how it...
I think most Java programmers call a program crash with a stacktrace a "crash" and hs_err_pids as a "VM crash".
> Do I have to somehow request review or just wait untill someone eventually does it? I think @lahodaj would review as Jan's assigned to the JBS issue. This patch...
Indeed, I put the JBS issue to target release 24. I believe given the potential behavioral changes, rushing into release 23 is a risky choice. (the 4 new tests can...