Chen Liang

Results 625 comments of Chen Liang

@eliminer You need to install baubles mod with thaumcraft. click on that link to download baubles jar and put it in the same `mods` folder as the thaumcraft jar.

@jbduncan I do not think trees are directed. They are undirected graph having n vertexes and n-1 edges.

For the tree, will we have some sort of `TreeBuilder` which take undirected and directed cases into different accounts?

@jbduncan > which describes how, in this system, entity1 must receive msg1 before entity2 receives msg2. For my work, it doesn't matter where msg1 and msg2 come from. Let's say...

Unfortunately we have to defer this to release 24 now, and seems only @lahodaj know about jshell well enough for a review.

Nice changes! Remarks 1. The `INSTANCE` fields should be declared `final`, still safe for lazy initialization. 2. Not from this patch, but the `AttributeStability stability()` overrides can be moved to...

Also the `final` modifier addition should be included in the CSR, as it changes the access modifiers even if it has no real impact.

Yeah, it has no real usage impact but such changes do require CSRs, like https://bugs.openjdk.org/browse/JDK-8305158 for a `final` on `Arrays` class, so you should include the `final` modifier change in...