Chen Liang comments

Results 625 comments of


                                            Chen Liang

8328536: javac - crash on unknown type referenced in yield statement

langtools tier 1+2 tests pass. /sponsor

8330465: Stable Values and Collections (Internal)

Also, I want to mention a few important differences between `@Stable` and Stable Values: Patterns: 1. Benign race (does not exist in StableValue API): multiple threads can create an instance...

8330465: Stable Values and Collections (Internal)

@minborg Just curious, why are you adding holder-in-holder benchmark cases?

8330465: Stable Values and Collections (Internal)

Just curious, can you test other samples, like `StableValue` where the contained `List` is an immutable list from `List.of` factories? I think that would be a meaningful case too. Also...

8330465: Stable Values and Collections (Internal)

Thanks for the insights. Also, I wonder what is a good amount of metadata you are considering, as original stable values only take one possible representation out of all to...

8292955: Collections.checkedMap Map.merge does not properly check key and value

@minborg Is it possible for you to review this collection bugfix?

8331670: Deprecate the Memory-Access Methods in sun.misc.Unsafe for Removal

Should `Unsafe.pageSize` be deprecated for removal too?

8320396: Class-File API ClassModel::verify should include checks from hotspot/share/classfile/classFileParser.cpp

> So I'm not clear at what point you would run these JVMS defined structural verification checks that you are adding? This is more like an addon module to Class-File...

8332109: Convert remaining tests using com.sun.tools.classfile to ClassFile API

Thanks for the review! /integrate

8321274: Rename ZipEntry.extraAttributes to ZipEntry.externalFileAttributes

I believe this field only captures the 2 bytes at higher indices of External File Attribute; it's not the complete 4-byte external file attributes and this value is not captured...