Chen Liang

Results 625 comments of Chen Liang

Also I meant to add `Objects.requireNonNull` calls than `@NotNull` annotations.

Can probably be replaced by #2172

Hmm, since fabric loader calls main by reflection, isn't any throwable from there wrapped in an [invocation target exception](https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/lang/reflect/InvocationTargetException.html) than be thrown directly as in method handles? https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/lang/reflect/Method.html#invoke(java.lang.Object,java.lang.Object...)

Hmm, if game falters before launch, where do the sys out stuff go to?

So fabric loader would act as a secondary launcher that reports its own errors, I assume.

@sfPlayer1 Requesting a review on the overall design of this API. Imo the overall design and the implementation details are good enough (as I've approved it long ago). Notice that...

@sfPlayer1 player, how do you think of this one?

Task output I believe, like how mixin annotation processor always emitted a message. If a user uses bare yarn with only class and member mappings without generating source, either way,...

Not really possible and feasible; vanilla intends them to be loaded in the same class loader, and fabric should probably do the same.