fabric icon indicating copy to clipboard operation
fabric copied to clipboard

Create the fabric-dynamic-registry-api-v1 module

Open haykam821 opened this issue 5 years ago • 5 comments

This pull request adds the fabric-dynamic-registry-api-v1 module. This module is used by implementing DynamicRegistryProvider in a dynamic-registry-provider entrypoint.

haykam821 avatar Aug 19 '20 21:08 haykam821

So without the discussion on Discord, I'd have no clue what this is actually used for. Apparently its for mods to add their own completely separate, dynamic registry, which allows them to have it populated from JSON files (using their own Codec to decode), and have it synced to the client.

shartte avatar Aug 19 '20 22:08 shartte

This module now needs to define a module lifecycle: For the new module you would add the following to the fabric.mod.json

  "custom": {
    "fabric-api:module-lifecycle": "stable"
  }

i509VCB avatar Jan 19 '21 20:01 i509VCB

Already did 😛

haykam821 avatar Jan 19 '21 20:01 haykam821

lmao I didn't see then :laughing:

i509VCB avatar Jan 19 '21 20:01 i509VCB

@sfPlayer1 Requesting a review on the overall design of this API.

Imo the overall design and the implementation details are good enough (as I've approved it long ago). Notice that fabric has since updated the gradle buildscript for modules, and 1.17 port can make use of records.

liach avatar Jun 15 '21 15:06 liach

There have been far too many changes affecting DRM that this PR should probably be remade from scratch. Closing.

apple502j avatar Nov 30 '22 05:11 apple502j