jquery-popupwindow icon indicating copy to clipboard operation
jquery-popupwindow copied to clipboard

Add object only api

Open thorst opened this issue 10 years ago • 5 comments

Allow user to only pass in an object, with a key for url. This commit maintains backwards compatibility.

This is optional, I like passing 1 (potentially complex) object to a function. This is cleaner in my opinion, and for only a couple of lines I think its should be added in the base project.

I use this by defining a set of defaults I always want to use, then when I'm ready to call the plugin I extend my setting array with the specifics of that call.

Again, this is purely preference, but I prefer this api, and others may also.

thorst avatar Apr 18 '14 17:04 thorst

Hows that?

thorst avatar Apr 21 '14 11:04 thorst

Looks good. Could you update the readme to reflect this change? @mkdynamic what do you think about this?

lencioni avatar Apr 22 '14 04:04 lencioni

Ill do that today.

thorst avatar Apr 22 '14 11:04 thorst

Any chance this could land?

thorst avatar Jul 08 '14 00:07 thorst

Looks good to me fwiw. @lencioni

mkdynamic avatar Jul 08 '14 00:07 mkdynamic