Luis Enrique Muñoz Martín

Results 204 comments of Luis Enrique Muñoz Martín

Ok, I see...

I think we can consider this ready, and can be merged. Anyways the branch MUST NOT BE REMOVED

@cdamian do you want to hit the button? 🚀 We MUST keep the branch, do not remove it!!

Do not remove the branch! 🙏🏻

@cdamian is your last fudge adventure did you have a chance to know if this is feasible?

Cool! I just see that the error is also returned in the macro expansion. More cool!

After searching about this, it seems not possible. Nothing except a string of the error is propagated (https://github.com/paritytech/polkadot-sdk/blob/master/substrate/utils/frame/rpc/system/src/lib.rs#L164). The error could later be read in the event, but you need...

BTW, I think most of the conflicts with `main` comes from `to_account_id()` changes in removed files. I think should be easy to fix them. But happy to help if you...

This PR is 100% tests, right? Can we add it after doing the RU in case we lack time?

The problem I see is that this PR will create a big amount of conflicts with `polkadot-1.7.2` I guess, because it's over `main`. So maybe it puts a big delay...