Luis Enrique Muñoz Martín
Luis Enrique Muñoz Martín
Probably `clippy` will complain with the `if let/else` structure to change it to a `match`
Thanks for the awesome PR description! ❤️ Very helpful
**This is still super super WIP**
Should be ready to be merged after reviewing it: @mustermeiszer @hieronx
> What is the reason for the DAY_1 restriction, just out of interest? The cashflow date/interval computation gets harder to compute with several border cases, i.e., the user sets day...
Makes sense! I like this bottom-up approach. Will do so. > calculate the cashflow as if ALL needs to be paid at maturity That would increase the resulting interest a...
For future reference. Copy the following to the end of `ensure_can_borrow()` when restrictions apply again: ```rust let expected_payment = self.schedule.expected_payment( self.repayments_on_schedule_until, self.principal()?, self.pricing.interest().rate(), now, )?; ensure!( self.total_repaid.effective()? >= expected_payment, Error::::from(BorrowLoanError::PaymentOverdue)...
`breaks-api` tag due: - Loans API to V3 (not exactly breaking) - `InterestPayments::None` renamed to `InterestPayments::OnceByMaturity`
External loans are not working as expected in this PR. Added the required changes in a new PR to ease review what's needed: https://github.com/centrifuge/centrifuge-chain/pull/1864 (WIP)
Closed in favor of a simplified version: https://github.com/centrifuge/centrifuge-chain/pull/1867 Keeping this as a backup to recover the monthly cashflow