centrifuge
Polkadot v1.1.0
I see we are using Moonbeam as a dependency, but only for testing. Do we really need it? It's very painful to work with. Could we get rid of it?
@lemunozm Are you referring to any particular dependency or basically everything that comes from - https://github.com/moonbeam-foundation/moonbeam ?
Most of those things are used for XCM-related tests such as the pallet-xcm-transactor and I'm not sure if we wanna drop those just now.
I meant everything coming from Moonbeam. Are we sure we wanna tie the fudge development to different versions of Moonbean just for testing? Could we not test xcm without using moonbeam?
~~By the way, doing a cargo test in the repo fails due the testing part and Moonbeam stuff is not migrated~~
EDIT: My fault, tests work well!
@lemunozm I'm re-checking the tests now, it might be possible that I only checked the fudge-core and missed the rest, sorry about that, will fix asap.
As far as the tests go - I'm not sure if we want to drop the XCM tests, maybe @mustermeiszer can share his opinions on this one.
Then, for having the XCM test, we are forced to be tied to the Moonbeam. Is there no other possibility?
@lemunozm we really need pallet-xcm-transactor for those tests if we are to confirm that everything works correctly. Otherwise, we'll have to use something like we had before, that mocked the whole xcm setup.
Otherwise, we'll have to use something like we had before, that mocked the whole xcm setup.
And that mock reduced the coverage of the fudge code?
@lemunozm in a way, yes, since it wasn't using the actual XCM parts such as the downward message queue, XCMP queue and so on.
I think we can consider this ready, and can be merged. Anyways the branch MUST NOT BE REMOVED
@cdamian do you want to hit the button? 🚀
We MUST keep the branch, do not remove it!!