LB (Ben Johnston)

icon indicating a website link https://lb.ee icon indicating an email [email protected]

icon company Virgin Australia icon location Brisbane, Australia icon location LB (pronounced ‘Albi’), love coffee, systems, travel, technology and also coffee. Incredibly thankful for my amazing wife Bec and son Leo.

Results 1054 comments of LB (Ben Johnston)

Refactoring wagtail.contrib.redirects.views into a class based views

Closing in favour of newer PR. https://github.com/wagtail/wagtail/pull/11762

MutationObserver in dirty form check only tests direct descendants

I think your suggestion makes sense.

MutationObserver in dirty form check only tests direct descendants

https://github.com/wagtail/wagtail/pull/11373 has migrated this logic to Stimulus. It's still the same mutation observer under the hood but might make it easier to write unit tests for these edge cases and...

MutationObserver in dirty form check only tests direct descendants

Awesome @kituuu - add comments to this issue if you have questions about the approach to take.

MutationObserver in dirty form check only tests direct descendants

@SebCorbin do you mind helping out @kituuu here - do you have a simple widget code snippet that could be used on bakerydemo to reproduce this scenario. As for the...

MutationObserver in dirty form check only tests direct descendants

Note. I manually validated this bug when reviewing the PR.

Telepath - give form widget adapters a mechanism for obtaining bound widgets for existing form elements

Just adding some thoughts here, we will need to consider the implications for non-core Wagtail widgets that are instantiated by other means. I also think that over-reliance on form elements...

drop support for python 3.6 and 3.7

A potential simpler solution could be a Django app setting that allows filenames to be automatically shortened if over the limit. This avoids the complexity of an additional UI interaction...

drop support for python 3.6 and 3.7

@jalajk24 this may not be a good first issue, you would need to be familiar with Django app settings, images / documents in Wagtail (including the various ways files can...

drop support for python 3.6 and 3.7

@salty-ivy - the actual limit (restriction) number may come from Django. I think this issue needs a bit more investigation such as. - Why 100chars - where is the actual...