LB (Ben Johnston)
LB (Ben Johnston)
I will try to take a look at this but I know @laymonage is also actively working in this space (CBV adoption). Thanks @rohitsrma !
By the looks of things, it's only used for the template code & examples. - lib/common/formats.js - examples/advanced/custom-formats-with-templates/build.js - examples/advanced/tokens-deprecation/build.js - scripts/handlebars/templates/formats.hbs - lib/register/template.js I assume these need to still...
Thanks @Shreshth-Srivastava Hey @laymonage / @thibaudcolas - just flagging for review from design. I have been looking at https://github.com/wagtail/wagtail/pull/11756 and I agree with your comment on the issue that we...
@zerolab feel free to give this a test against Wagtail `main` now - the progress button work has been done. Hopefully it works better for this use case now.
See potentially related/similar issue - https://github.com/wagtail/wagtail/issues/6919
If there's ever a discussion about a library. I'd recommend looking into TipTap. It's got a solid amount of momentum, with a large community base and is very customisable. https://tiptap.dev/...
I have not read through this but looks like we could leverage the bulk-actions or counts controller here for better management of counting elements / changing behaviour based on counts...
Hey @elhussienalmasri - I've added a comment on the issue about a potentially different approach to this PR. https://github.com/wagtail/wagtail/issues/11561#issuecomment-2002196259 Best to chat on Slack about your GSoC question.
Thank you @rohitsrma I have flagged for a review.
Looks like this is a bit more tricky tricky than first thought, I had called out `idForLabel` but the PR submitted did not account for this. Here is a copy...